Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example: stream video capture over http #618

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

tidely
Copy link
Contributor

@tidely tidely commented Sep 14, 2024

No description provided.

@tidely
Copy link
Contributor Author

tidely commented Sep 14, 2024

Some checks seem to be failing. Older versions of opencv (3.x) appear to have VideoCapture::new_default instead of VideoCapture::new_def as in 4.x. Additionally VideoCaptureTrait doesn't appear to be used.

I'll switch to VideoCapture::new since it's consistent across all versions. A workaround for the VideoCaptureTrait would be to import the prelude, but I'd prefer putting a #[allow(unused_code)] and leave a comment explaining why. @twistedfall which way would you prefer it

@tidely tidely marked this pull request as draft September 14, 2024 20:23
@twistedfall
Copy link
Owner

I’d say don’t bother to support v3.4 too much. Do it only if it’s easy. This branch doesn’t seem to be supported upstream anymore so I expect to deprecate it too in the not so distant future.

@tidely tidely marked this pull request as ready for review September 15, 2024 21:25
Result type doesn't need to be opencv::Result when we use a boxed error anyway
@twistedfall twistedfall merged commit 61d1931 into twistedfall:master Sep 16, 2024
15 checks passed
@twistedfall
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants