bind to 0.0.0.0 instead of localhost #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SputNikPlop
reviewed
Dec 3, 2023
| @@ -80,7 +82,7 @@ func loginCmdRun(cmd *cobra.Command, args []string) error { | |||
| p.URL = login.ValidateTokenURL | |||
| r, err := login.ValidateCredentials(p) | |||
| if err != nil { | |||
| return fmt.Errorf("Failed to validate: %v", err.Error()) | |||
| return fmt.Errorf("failed to validate: %v", err.Error()) | |||
There was a problem hiding this comment.
@Xemdo Did you still want to keep this uppercase or lowercase?
There was a problem hiding this comment.
Lowercase is fine, since it matches Twitch's errors returned over HTTP. However since this is on console, it doesn't really matter too much as long as its readable.
Xemdo
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem/Feature
The
twitch token -ucommand was broken on WSL2 machines as it bound tolocalhostby default. Unfortunately this lead to the case where the webserver was local to the WSL2 image only, thus being inaccessible to the Windows host itself.This now binds the webserver to
0.0.0.0by default, and then allows this to be overridden by passing the--ipflag whilst not affecting the rediect URL as it was before using a new--redirect-host.Description of Changes:
--redirect-hostflag that allows for changing the redirect URL without affecting the webserver bindingChecklist