This repository has been archived by the owner on Sep 18, 2021. It is now read-only.
Introduction of smpp 3.4 spec compliant err code on delivery receipts. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well as maintaining backward compatibility of the int value
|
Included in release 5.0.4 which I just pushed to maven central (which will take ~24 hours to sync from sonatype). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the #rawErrorCode on DeliveryReceipt as a String. If the #setRawErrorCode can parse the value to an integer it will set the value (e.g. 000 => 0, 21b => noop). The toShortMessage function now uses #rawErrorCode as this value will always be set appropriately.