javascript fix to https connection to http Presto server #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Could you also submit this to upstream presto. When describing the issue it's helpful to explain that in our environment the client connects to a proxy via https which proxies to presto via http. Also please link this to the presto ticket, so we can easily back merge into twitter-master with any changes that come during the presto review. |
|
will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without configuring Presto server with SSL and require all users to access via https, when https requests go to an http Presto server, the server responds with nextUri specified in http which causes jquery to be blocked and hangs the page from loading.
This change uses javascript to detect mode, and if it's https it will modify returned nextUri from http to https.