Add test for MapAlgebra.sumByKey with a Unit value #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has a potentially deeper ramification for scalding: this means that we can't use MapAlgebra, becasue we could be throwing away rows (if they are equal to the zero) |
| @@ -120,6 +120,11 @@ object CollectionSpecification extends Properties("Collections") { | |||
| !MapAlgebra.removeZeros(m).values.toSet.contains(0) | |||
| } | |||
|
|
|||
| property("MapAlgebra.sumByKey with Unit works") = forAll { l: Set[String] => | |||
| val lst = l.toList | |||
| l == MapAlgebra.sumByKey((lst ++ lst ++ lst).map((_, ()))).keys | |||
There was a problem hiding this comment.
you need to use MapEquiv here. () is the unit of this type, so this is not a failing test case. This is the expected behavior.
I would expect that you may get Map.empty here.
|
I'm going to close here and just remove the use of MapAlgebra in scalding, since sparse summing isn't what we want |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cause of the error in twitter/scalding#935