Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default local maven repo to the resolver list #1024

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

gerashegalov
Copy link
Contributor

No description provided.

@johnynek
Copy link
Collaborator

I'm pretty skeptical of this. Do we really need this in the main repo?

@jcoveney
Copy link
Contributor

Isn't this something people can add to their own sbt or ivy configurations?

@gerashegalov
Copy link
Contributor Author

@johnynek it's useful for quick iterations working on a dependency to avoid poluting a central repo with unnecessary builds.

@jcoveney If this can be achieved with a simple config, I am all for it. I am new to sbt.

@gerashegalov gerashegalov changed the title Add defaul local maven repo to the resolver list Add default local maven repo to the resolver list Aug 19, 2014
@gerashegalov
Copy link
Contributor Author

@jcoveney according to http://www.scala-sbt.org/release/tutorial/Library-Dependencies.html and other forums I found by googling that's actually the way to do it with sbt.

I think there are no real reservations against this change because this is just a normal way you would expect to share artifacts via maven locally when working on multiple projects.

@julienledem
Copy link
Contributor

This looks reasonable to me. This is what maven does by default allowing for local deployment (install) of artifacts. This makes working on cross project changes easier.
@johnynek Does SBT have a default mechanism for a local repo? any strong opinion against this?

@ianoc
Copy link
Collaborator

ianoc commented Aug 21, 2014

Sbt by default uses ivy for a local repo which is why we haven't seen this before. When installing artifacts for local usage we install them into both the maven and ivy repos in our usual flow between our OSS repos. A pure maven repo rather than SBT would probably find this more difficult. If there are no objections I'll merge this later as a harmless parity level thing between .ivy and .m2

ianoc added a commit that referenced this pull request Aug 29, 2014
Add default local maven repo to the resolver list
@ianoc ianoc merged commit bd309a6 into twitter:develop Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants