Fixed type of exception thrown by validateTaps #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API specifies that validateTaps should throw InvalidSourceException, rather than IllegalArgumentException
The API specifies that validateTaps should throw InvalidSourceException, rather than IllegalArgumentException
| "Version %s does not exist. Currently available versions are: %s" | ||
| .format(version, store.getAllVersions)) | ||
| } | ||
| } | ||
|
|
||
| case _ => throw new IllegalArgumentException( | ||
| case _ => throw new InvalidSourceException( |
There was a problem hiding this comment.
This one isn't recoverable is it? do we want this one to be the old exception maybe?
There was a problem hiding this comment.
We do not have a choice, given the API specification (and there is code that depends on that
specification being observed). See https://github.com/twitter/scalding/blob/develop/scalding-core/src/main/scala/com/twitter/scalding/Source.scala#L154
|
Agree that sources are supposed to throw InvalidSource in validateTaps. Good catch. |
johnynek
added a commit
that referenced
this pull request
Sep 3, 2014
Fixed type of exception thrown by validateTaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API specifies that validateTaps should throw InvalidSourceException, rather than IllegalArgumentException