Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respects -Dmapred.job.name when passed in on the command line #1045

Merged
merged 1 commit into from
Sep 11, 2014

Conversation

daveFNbuck
Copy link
Contributor

This allows users to pass -Dmapred.job.name= on the command line in order to see in the job tracker instead of the class name. It still defaults to the class name if nothing is passed.

@@ -116,7 +116,7 @@ class Job(val args: Args) extends FieldConversions with java.io.Serializable {
RichPipe(toPipe(iter)(set, conv))

// Override this if you want to change how the mapred.job.name is written in Hadoop
def name: String = getClass.getName
def name: String = Config.defaultFrom(mode).toMap.getOrElse("mapred.job.name", getClass.getName)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this work? I think it will just change the class name part that you have.

I think it is fine to add, but I am not sure it closes #1044

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not meant to close #1044. This is a separate issue.

johnynek added a commit that referenced this pull request Sep 11, 2014
Respects -Dmapred.job.name when passed in on the command line
@johnynek johnynek merged commit 7de1c82 into twitter:develop Sep 11, 2014
@johnynek
Copy link
Collaborator

Thanks, @daveFNbuck . Great working with you again. :)

@daveFNbuck daveFNbuck deleted the mapred_job_name branch September 11, 2014 04:55
@daveFNbuck
Copy link
Contributor Author

anytime

On Wed, Sep 10, 2014 at 7:18 PM, P. Oscar Boykin notifications@github.com
wrote:

Thanks, @daveFNbuck https://github.com/daveFNbuck . Great working with
you again. :)


Reply to this email directly or view it on GitHub
#1045 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants