Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnynek Failing test in globifier...
[error] x Globifiers should
[error] x handle specific hand crafted examples
[error] 'List(/2014/06/30/, /2014/07//)' is not equal to 'List(/2014/06/30/, /2014/07/01/00)' (DateTest.scala:250)
Do you know the lineage of https://github.com/twitter/scalding/blob/develop/scalding-date/src/main/scala/com/twitter/scalding/Globifier.scala#L37
looks very old. I think its taking the range to be an exclusive upper bound but its actually an inclusive upper bound on the range?