Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in failing test case #1090

Merged
merged 2 commits into from
Nov 8, 2014
Merged

Add in failing test case #1090

merged 2 commits into from
Nov 8, 2014

Conversation

ianoc
Copy link
Collaborator

@ianoc ianoc commented Nov 7, 2014

@johnynek Failing test in globifier...

[error] x Globifiers should
[error] x handle specific hand crafted examples
[error] 'List(/2014/06/30/, /2014/07//)' is not equal to 'List(/2014/06/30/, /2014/07/01/00)' (DateTest.scala:250)

Do you know the lineage of https://github.com/twitter/scalding/blob/develop/scalding-date/src/main/scala/com/twitter/scalding/Globifier.scala#L37

looks very old. I think its taking the range to be an exclusive upper bound but its actually an inclusive upper bound on the range?

@johnynek
Copy link
Collaborator

johnynek commented Nov 8, 2014

I don't remember the history of this line at all. Better comments on something so tricky would be good. More tests pass now, so I guess we should merge, but I am also concerned that the random tests never failed but this one did. I wonder how strong our random tests are. I added an issue: #1091

johnynek added a commit that referenced this pull request Nov 8, 2014
@johnynek johnynek merged commit d10e03f into develop Nov 8, 2014
@johnynek johnynek deleted the globifierBug branch November 8, 2014 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants