Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos in TypedPipe docs, expand flatMap docs #1115

Merged
merged 3 commits into from
Dec 5, 2014

Conversation

isnotinvain
Copy link
Contributor

No description provided.

@@ -265,11 +273,11 @@ trait TypedPipe[+T] extends Serializable {
def fork: TypedPipe[T] = onRawSingle(identity)

/**
* WARNING This is dangerous, and maybe not what you think.
* WARNING This is dangerous, and maybe not be what you think.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not be? or may not be?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. "maybe not what you think" makes sense to me now.
ok how about "and may not be what you think"?

@johnynek
Copy link
Collaborator

johnynek commented Dec 5, 2014

when this looks good run:

./sbt unidoc
./sbt ghpages-push-site

to update the scaladoc (but it caches so you might need incognito or something to verify the upload, I couldn't do it with a force reload maybe due to the frames).

@isnotinvain
Copy link
Contributor Author

OK, should we merge and then update the scaladoc?

johnynek added a commit that referenced this pull request Dec 5, 2014
Fix some typos in TypedPipe docs, expand flatMap docs
@johnynek johnynek merged commit 45c32e1 into develop Dec 5, 2014
@johnynek johnynek deleted the alexlevenson/typos branch December 5, 2014 17:27
@johnynek
Copy link
Collaborator

johnynek commented Dec 5, 2014

push to gh-pages to see the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants