Ianoc/case class tuple converters #1131
Conversation
| expandMethod(tpe.declarations | ||
| .collect { case m: MethodSymbol if m.isCaseAccessor => m }, | ||
| q"""$pTree.$accessorMethod""") | ||
| case _ => List((idx: Int) => q"""tup.set(${idx}, t.$accessorMethod)""") |
There was a problem hiding this comment.
shouldn't we abort here? I thought we are doing the flattening only on primitive types.
There was a problem hiding this comment.
Thats a good question, I can see the argument going either way, you can do a setObject in cascading. Should we allow that or just throw?
There was a problem hiding this comment.
What is the use case here? For Pig, the data people write is generally (always?) just primitive + strings right? Also, for DB it is the same thing. So, I would tend to say it would be good to error in this case.
We could take a boolean to onlySimpleTypes: Boolean or something.
| import com.twitter.bijection.macros.IsCaseClass | ||
|
|
||
| object Macros { | ||
| def caseClassTupleSetter[T: IsCaseClass]: TupleSetter[T] = macro MacroImpl.caseClassTupleSetterImpl[T] |
There was a problem hiding this comment.
we should document here that these only work when the case class is "simple" (primitive + string) or nested simple.
Ianoc/case class tuple converters
|
Changes Unknown when pulling af7cb52 on ianoc/caseClassTupleConverters into * on develop*. |
|
so mysterious... Why is coveralls pinging this 1.5 year old PR!? |
Tests won't pass as relies on macro code in an as yet un-released version of bijection