Hydrate both sides of sampledCounts in skewJoinWithSmaller #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Augment sampledCounts in JoinAlgorithms#skewJoinWithSmaller to avoid dropping items when keys get filtered by sampling
Accumulate the results instead of just computing the append. Also make input1 smaller to more easily expose sampling issues.
|
nice work tracking this down. It is so sad this has been causing subtle errors for years |
johnynek
added a commit
that referenced
this pull request
May 8, 2015
Hydrate both sides of sampledCounts in skewJoinWithSmaller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1277
The test fixes here are sufficient to make two tests fail, both of which are fixed with this change.