make some repl components extensible #1342
Conversation
Merge from twitter/scalding
Merge from twitter/scalding
Merge from twitter/scalding
| @@ -77,14 +82,16 @@ class ScaldingILoop | |||
| */ | |||
| override def commands: List[LoopCommand] = super.commands ++ scaldingCommands | |||
|
|
|||
| protected def shellImports: List[String] = List( | |||
There was a problem hiding this comment.
could this be moved to BaseScaldingShell so there is only one place to configure if it makes sense?
|
If we could have some trait like |
| @@ -178,7 +183,8 @@ object ReplImplicits extends FieldConversions { | |||
| * @param source to convert to a Pipe. | |||
| * @return a Pipe that is the result of reading the specified Source. | |||
| */ | |||
| implicit def sourceToPipe(source: Source): Pipe = source.read(flowDef, mode) | |||
| implicit def sourceToPipe(source: Source)(implicit flowDef: FlowDef, mode: Mode): Pipe = | |||
There was a problem hiding this comment.
I really don't think we need this. I think it was just cargo culted from Dsl by the (wibidata folks that started the REPL).
|
if the args change makes sense, I'm happy to merge. |
|
I made a few more changes and moved the prompt & imports to The main issue is that I've made |
|
I think this is an improvement. I'm happy to merge this. @ianoc want to merge if you think this looks good? |
make some repl components extensible
|
LGTM, merged |
Allows for setting custom implicits and config to load at boot time.