Add monoid and semigroup for Execution #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! I love this! +1 |
|
If it'll be used to sum, should we add sumOption which uses Execution.sequence? |
|
I thought about that, but that would force us to materialize an Iterator of these into a Sequence, just to get the sumOption. It's not clear that is always a win. Instead, this is incremental and less code. If you prefer, I can do it, but given that Execution is generally VERY slow code (it talks to the cluster in the interesting cases), I thought it was better to default to the smaller memory case. |
|
@jnievelt let me know either way. |
|
@johnynek sure sgtm, can always add it later |
johnynek
added a commit
that referenced
this pull request
Jul 21, 2015
Add monoid and semigroup for Execution
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added for completeness. Probably only real application is:
Monoid.sum(actionList: List[Execution[Unit]]): Execution[Unit]which can be nice to combine a bunch of independent execution jobs into one.