Add withConfig api to allow running an execution with a transformed config #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the cache key needs to include the config if we do this. Also, if we go this route, I would say we change |
|
I like this idea, will help in many cases where we have to go wide on a source using splits map side but want to write larger files to hdfs at the end of a job. Currently there is not much choice aside from using .shard |
| @@ -209,6 +209,9 @@ object Execution { | |||
| override def join[T, U](t: Execution[T], u: Execution[U]): Execution[(T, U)] = t.zip(u) | |||
| } | |||
|
|
|||
| def withConfig[T](ex: => Execution[T])(c: Config => Config): Execution[T] = | |||
There was a problem hiding this comment.
if this is lazy, the arg in the constructor needs to be, otherwise this should not be lazy.
|
Looks great! (1 minor issue) |
|
Killed the lazy, not useful I don't think here |
|
Good to go now @johnynek ? |
ianoc
changed the title
johnynek
added a commit
that referenced
this pull request
Feb 9, 2016
Add withConfig api to allow running an execution with a transformed config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the the ability to transform Config's (and hence args) for sub-sections of Execution flows. This can be useful to override hadoop or source level options in subsections. This lets the user have more control over things like split sizes, memory used in mappers/reducers, combining small files, etc..