-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for more formats to work with RichDate #1522
Conversation
@@ -38,14 +42,19 @@ object DateOps extends java.io.Serializable { | |||
} | |||
|
|||
private[scalding] object Format { | |||
private val normalDate = """\d{4}\d{2}\d{2}""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we put a better name on this? dateWithoutSep maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. my bad!!.. I will change that..
Overall looks good to me, just some minor style nits |
@ianoc Thanks for pointing out... |
@ianoc pls see if this ok for you to merge |
@@ -38,14 +42,19 @@ object DateOps extends java.io.Serializable { | |||
} | |||
|
|||
private[scalding] object Format { | |||
private val dateWithoutSep = """\d{4}\d{2}\d{2}""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this just \d{8}
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah...il do that.. My bad !!
I have made the changes required. |
support for more formats to work with RichDate
Thanks! |
No description provided.