Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for more formats to work with RichDate #1522

Merged
merged 6 commits into from
Feb 25, 2016

Conversation

afsalthaj
Copy link
Contributor

No description provided.

@@ -38,14 +42,19 @@ object DateOps extends java.io.Serializable {
}

private[scalding] object Format {
private val normalDate = """\d{4}\d{2}\d{2}"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we put a better name on this? dateWithoutSep maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. my bad!!.. I will change that..

@ianoc
Copy link
Collaborator

ianoc commented Feb 21, 2016

Overall looks good to me, just some minor style nits

@afsalthaj
Copy link
Contributor Author

@ianoc Thanks for pointing out...
Could you please point out in general on those minor style nits... Never want to change the existing styles the project has been following

@afsalthaj
Copy link
Contributor Author

@ianoc pls see if this ok for you to merge

@@ -38,14 +42,19 @@ object DateOps extends java.io.Serializable {
}

private[scalding] object Format {
private val dateWithoutSep = """\d{4}\d{2}\d{2}"""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this just \d{8}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...il do that.. My bad !!

@afsalthaj
Copy link
Contributor Author

I have made the changes required.

johnynek added a commit that referenced this pull request Feb 25, 2016
support for more formats to work with RichDate
@johnynek johnynek merged commit 557d138 into twitter:develop Feb 25, 2016
@johnynek
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants