-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chill version to 0.8.3 #1634
Conversation
This may change the serialization of things that are using kryo for storage (which they shouldn't do, but people don't always do the right thing). We should definitely do a version bump here. We should definitely not publish a new version, in my opinion, until we can do 2.12 at the same time. |
I agree on both. Also I need to investigate travis build failure. |
Issue is:
looks like a legit test failure. I guess something changed and void is somehow showing up and breaking that test. |
3b37358
to
9b657b0
Compare
@johnynek Since 3.x (actually since some 2.x version) Kryo includes serializer for I added If we are going to release it with 2.12 release should we merge this change to develop branch? |
seems fine to me. I think this looks good now. I assume you want to merge so you can do branch publish to get summingbird tested with storm 1.0.2? |
@johnynek I've done internal twitter release already, so it's better for me to keep it merged but I'm ok either way. What I really need is - to release scalding with new chill to bump scalding version in summingbird branch to make it mergeable (otherwise two versions of kryo come to summingbird classpath). Also I want to bump scalding dependency in storehaus before storehaus release. |
I'm fine to merge it. I'm actually anxious to move many of these
dependencies forward.
…On Tue, Jan 17, 2017 at 16:28 Timur ***@***.***> wrote:
@johnynek <https://github.com/johnynek> I've done internal twitter
release already, so it's better for me to keep it merged but I'm ok either
way.
What I really need is - to release scalding with new chill to bump
scalding version in summingbird branch to make it mergeable (otherwise two
versions of kryo come to summingbird classpath). Also I want to bump
scalding dependency in storehaus before storehaus release.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1634 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJds1MZkjMjxPLoRWRoW6XVqyu0We-ks5rTXjDgaJpZM4LmFJn>
.
|
In order to have https://github.com/twitter/summingbird working with new storm API we need to depend on kryo 3.0 and therefore one chill 0.8.x. This PR bumps chill dependency to 0.8.3.