Request for Scalding release 0.17.0 #1641
Conversation
|
cc @isnotinvain / @johnynek / @pankajroark / @ttim |
|
SGTM -- can you post the binary breaking changes (mima should tell you right)? |
|
Sure, they're here: https://gist.github.com/piyushnarang/eab87e4ed8f7a4878cb102df5f28bb51 |
|
could we possibly hold off just a bit and publish all the projects below (chill with algebird 0.13.0), bijection? Then use the latest of those and get us ready for 2.12? We use chill-algebird here, but the chill-algebird we use is for the old algebird, so I don't think we want that. |
|
@johnynek sure. I think we need to publish of chill with algebird 0.13. Bijection doesn't depend on algebird right? - https://github.com/twitter/bijection/blob/develop/build.sbt. (Unless you're referring to pulling in the bijection version 0.9.5 thats on 2.12 in Scalding prior to this release). |
|
yeah, you are right, the other way around: https://github.com/twitter/algebird/blob/develop/build.sbt#L11 |
|
@johnynek is someone working on the chill publish? |
|
@piyushnarang not that I know of. |
|
Ok, we have the various chill artifacts out. 0.7.7 is the version that we can pick up in Scalding. |
|
@piyushnarang Scalding currently depends on 0.8.x branch of chill, do we want it to depend on 0.7.x branch again? This dependency required for SB... |
|
@ttim I released chill 0.7.7, 0.8.4 and 0.9.2 (https://github.com/twitter/chill/releases). All 3 of these versions pick up Algebird 0.13.0. In my Scalding PR, I'm picking up 0.8.4 - #1646. |
|
So, I think we assumed that we would do Maybe it makes sense to have 1 more Also note, I think there are no binary incompatible changes actually, so I think a user could use scalding with chill 0.8 now, but they need to realize the serialization may change (but that should not be an issue unless the user themselves has persisted some kryo data, which they should never do and if they do they must realize they have to accept responsibility for making it work correctly). |
|
by the way, we really need include #1636 before 0.17. It makes a HUGE difference for us in a forked version and its a bummer for the default to be so slow. |
|
Yeah I don't mind either. Currently it seems like we are depending on chill (0.8.x) in Scalding and 0.7.x in Summingbird. Our internal Summingbird seems to be dependent on 0.8.x. @ttim correct me if I'm wrong. @johnynek any idea if anyone is working on #1636 as of now? We can't bump algebird internally cause it breaks a bunch of our other libraries so if this is out in the future would be nice to not block on it. |
|
Let's try to get the ones in progress merged. In particular the #1654 to
improve serialization could be a pretty big deal.
…On Wed, Mar 22, 2017 at 17:20 Piyush Narang ***@***.***> wrote:
Circling back on this. Now that we have the 2.12 PR merged (#1646
<#1646>), can we proceed with the
0.17.0 release? The only other PR that seems like an important inclusion is
@dieu <https://github.com/dieu>'s - #1647
<#1647>. Anything else? @johnynek
<https://github.com/johnynek> / @dieu <https://github.com/dieu> / @ttim
<https://github.com/ttim> / @isnotinvain <https://github.com/isnotinvain>
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1641 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAEJdq_QlNUYPz-1tRYfVsvgTt7UklyJks5roeUWgaJpZM4MCWr1>
.
|
|
can we not do 2.12? I didn't see it in the change. |
|
@johnynek yes we can. I didn't update this after our 2.12 PRs. I've added the 2.12 module list and dropped 2.10. |
|
@johnynek I think this is ready to be merged now. I've published the 0.17.0 artifacts (link to the draft release notes: https://github.com/twitter/scalding/releases/tag/v0.17.0). Also set the version to 0.17.1-SNAPSHOT. |
* Set Scalding version * Update versions to 2.11 and 2.12 * Bump version
Proposing a new Scalding release - 0.17.0. This release includes a major algebird version bump - 0.12.x -> 0.13.0 as well as some binary incompatible changes. If folks are onboard with this, I'll publish artifacts and make it official.
Here's a link to the release notes: https://github.com/twitter/scalding/releases/tag/v0.17.0