Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register all Boxed classes in Kryo #1678

Merged
merged 1 commit into from
May 2, 2017
Merged

Conversation

jcdavis
Copy link
Contributor

@jcdavis jcdavis commented May 1, 2017

They should never be kryo serialized (hence the ThrowingSerializer),
but this means they will be given cascading tokens.

Fixes #1524

They should never be kryo serialized (hence the ThrowingSerializer),
but this means they will be given cascading tokens.
Copy link
Collaborator

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnynek johnynek merged commit 9b70d7d into twitter:develop May 2, 2017
@jcdavis jcdavis deleted the boxed-tokens branch May 2, 2017 14:50
ttim pushed a commit to ttim/scalding that referenced this pull request May 16, 2017
They should never be kryo serialized (hence the ThrowingSerializer),
but this means they will be given cascading tokens.
jcdavis added a commit to jcdavis/scalding that referenced this pull request May 23, 2017
They should never be kryo serialized (hence the ThrowingSerializer),
but this means they will be given cascading tokens.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants