Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not inherit from FileSource in LzoTraits #976

Merged
merged 1 commit into from
Jul 26, 2014
Merged

Do not inherit from FileSource in LzoTraits #976

merged 1 commit into from
Jul 26, 2014

Conversation

amatsukawa
Copy link
Contributor

LzoProtobuf, LzoThrift, etc primarily serve to provide the hdfsScheme and do not actually use FileSource.
This change enables us to mixin LzoThrift into ParitionSource, for example.

@johnynek
Copy link
Collaborator

Nice catch.

@jcoveney
Copy link
Contributor

Welcome to working on scalding, Aki :)

@qqwjq1981
Copy link

Thanks Aki and Jon for the prompt response.

johnynek added a commit that referenced this pull request Jul 26, 2014
…aits

Do not inherit from FileSource in LzoTraits
@johnynek johnynek merged commit 65364be into twitter:develop Jul 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants