Improve TypedSimilarity algorithm and update test. #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val groupedOnSrc = graph | ||
| .filter { e => smallpred(e.to) || bigpred(e.to) } | ||
| val bigGroupedOnSrc = graph | ||
| .filter { e => bigpred(e.to) } |
There was a problem hiding this comment.
Hmm, I'm wondering if this might be one of the cases where a .forceToDisk or a .fork might be prudent. Thoughts, @johnynek ?
Also, you could do the map before applying the predicates, since we map them to the exact same thing.
There was a problem hiding this comment.
I can do the map first before creating two pipes using the predicates and add a .forceToDisk there. Is that more recommend?
There was a problem hiding this comment.
I don't think we need to add another. These two paths are separate since they are grouped differently.
jcoveney
added a commit
that referenced
this pull request
Jul 30, 2014
Improve TypedSimilarity algorithm and update test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one optimization to disco/dimsum algorithms: doing the filtering before the large self-join.
Update test to use TypedTsv.