This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 266
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #417 from twitter/feature/fix_merge_planner_bug
Feature/fix merge planner bug
- Loading branch information
Showing
6 changed files
with
227 additions
and
48 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
183 changes: 183 additions & 0 deletions
183
summingbird-online/src/test/scala/com/twitter/summingbird/online/PlannerSpec.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| /* | ||
| Copyright 2013 Twitter, Inc. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package com.twitter.summingbird.online | ||
|
|
||
| import com.twitter.algebird.{MapAlgebra, Semigroup} | ||
| import com.twitter.storehaus.{ ReadableStore, JMapStore } | ||
| import com.twitter.storehaus.algebra.MergeableStore | ||
| import com.twitter.summingbird._ | ||
| import com.twitter.summingbird.batch.{BatchID, Batcher} | ||
| import com.twitter.summingbird.memory._ | ||
| import com.twitter.summingbird.planner._ | ||
| import com.twitter.util.Future | ||
| import org.specs2.mutable._ | ||
| import scala.collection.JavaConverters._ | ||
| import scala.collection.mutable.{Map => MMap} | ||
| import org.scalacheck._ | ||
| import Gen._ | ||
| import Arbitrary._ | ||
| import org.scalacheck.Prop._ | ||
| import scala.util.{Try, Success, Failure} | ||
|
|
||
| /** | ||
| * Tests for Summingbird's Storm planner. | ||
| */ | ||
|
|
||
| object PlannerSpec extends Specification { | ||
| implicit def extractor[T]: TimeExtractor[T] = TimeExtractor(_ => 0L) | ||
| private type MemoryDag = Dag[Memory] | ||
| def sample[T: Arbitrary]: T = Arbitrary.arbitrary[T].sample.get | ||
|
|
||
| import TestGraphGenerators._ | ||
|
|
||
| implicit def sink1: Memory#Sink[Int] = sample[Int => Unit] | ||
| implicit def sink2: Memory#Sink[(Int, Int)] = sample[((Int, Int)) => Unit] | ||
|
|
||
| implicit def testStore: Memory#Store[Int, Int] = MMap[Int, Int]() | ||
|
|
||
| implicit val arbIntSource: Arbitrary[Producer[Memory, Int]] = | ||
| Arbitrary(Gen.listOfN(100, Arbitrary.arbitrary[Int]).map{ | ||
| x: List[Int] => | ||
| Memory.toSource(x)}) | ||
| implicit val arbTupleSource: Arbitrary[KeyedProducer[Memory, Int, Int]] = | ||
| Arbitrary(Gen.listOfN(100, Arbitrary.arbitrary[(Int, Int)]).map{ | ||
| x: List[(Int, Int)] => | ||
| IdentityKeyedProducer(Memory.toSource(x))}) | ||
|
|
||
|
|
||
| def arbSource1 = sample[Producer[Memory, Int]] | ||
| def arbSource2 = sample[KeyedProducer[Memory, Int, Int]] | ||
|
|
||
| "Must be able to plan user supplied Job A" in { | ||
| val store1 = testStore | ||
| val store2 = testStore | ||
| val store3 = testStore | ||
|
|
||
| val h = arbSource1.name("name1") | ||
| .flatMap{ i: Int => | ||
| List(i, i) | ||
| } | ||
| .name("name1PostFM") | ||
| val h2 = arbSource2.name("name2") | ||
| .flatMap{ tup : (Int, Int) => | ||
| List(tup._1, tup._2) | ||
| }.name("name2PostFM") | ||
|
|
||
| val combined = h2.merge(h) | ||
|
|
||
| val s1 = combined.name("combinedPipes") | ||
| .map{ i: Int => | ||
| (i, i * 2) | ||
| } | ||
|
|
||
| val s2 = combined.map{i : Int => | ||
| (i, i * 3) | ||
| } | ||
|
|
||
| val tail = s1.sumByKey(store1) | ||
| .name("Store one writter") | ||
| .also(s2) | ||
| .sumByKey(store2) | ||
|
|
||
| val planned = Try(OnlinePlan(tail)) | ||
| val path = TopologyPlannerLaws.dumpGraph(tail) | ||
|
|
||
| planned match { | ||
| case Success(graph) => true must beTrue | ||
| case Failure(error) => | ||
| val path = TopologyPlannerLaws.dumpGraph(tail) | ||
| error.printStackTrace | ||
| println("Dumped failing graph to: " + path) | ||
| true must beFalse | ||
| } | ||
| } | ||
|
|
||
| "Must be able to plan user supplied Job B" in { | ||
| val store1 = testStore | ||
| val store2 = testStore | ||
| val store3 = testStore | ||
|
|
||
| val h = arbSource1.name("name1") | ||
| .flatMap{ i: Int => | ||
| List(i, i) | ||
| } | ||
| .name("name1PostFM") | ||
| val h2 = arbSource2.name("name2") | ||
| .flatMap{ tup : (Int, Int) => | ||
| List(tup._1, tup._2) | ||
| }.name("name2PostFM") | ||
|
|
||
| val combined = h2.merge(h) | ||
|
|
||
| val s1 = combined.name("combinedPipes") | ||
| .map{ i: Int => | ||
| (i, i * 2) | ||
| } | ||
|
|
||
| val s2 = combined.map{i : Int => | ||
| (i, i * 3) | ||
| } | ||
|
|
||
| val s3 = combined.map{i : Int => | ||
| (i, i * 4) | ||
| } | ||
|
|
||
| val tail = s1.sumByKey(store1) | ||
| .name("Store one writter") | ||
| .also(s2) | ||
| .sumByKey(store2) | ||
| .name("Store two writer") | ||
| .also(s3) | ||
| .sumByKey(store3) | ||
| .name("Store three writer") | ||
|
|
||
| val planned = Try(OnlinePlan(tail)) | ||
| planned match { | ||
| case Success(graph) => true must beTrue | ||
| case Failure(error) => | ||
| val path = TopologyPlannerLaws.dumpGraph(tail) | ||
| error.printStackTrace | ||
| println("Dumped failing graph to: " + path) | ||
| true must beFalse | ||
| } | ||
| } | ||
|
|
||
| "Must be able to plan user supplied Job C" in { | ||
| val store1 = testStore | ||
|
|
||
| val src = arbSource1 | ||
| val h = src | ||
|
|
||
| val h2 = src.map(_ * 3) | ||
|
|
||
| val combined = h2.merge(h) | ||
|
|
||
| val c1 = combined.map{i: Int => i * 4} | ||
| val c2 = combined.map{i: Int => i * 8} | ||
| val tail = c1.merge(c2).map{i: Int => (i, i)}.sumByKey(store1) | ||
|
|
||
| val planned = Try(OnlinePlan(tail)) | ||
| planned match { | ||
| case Success(graph) => true must beTrue | ||
| case Failure(error) => | ||
| val path = TopologyPlannerLaws.dumpGraph(tail) | ||
| error.printStackTrace | ||
| println("Dumped failing graph to: " + path) | ||
| true must beFalse | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters