Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion is not closed in chrome/firefox . #259

Closed
houfeng0923 opened this issue May 24, 2013 · 3 comments
Closed

suggestion is not closed in chrome/firefox . #259

houfeng0923 opened this issue May 24, 2013 · 3 comments
Labels
Milestone

Comments

@houfeng0923
Copy link

Repro

  1. Open http://twitter.github.io/typeahead.js/examples/ on any Chrome, Firefox
  2. In Countries example, type "a"
  3. And click( just click,not enter|up|down keys) on the correct suggestion which is "Andorra"
  4. let input blur then focus
  5. Once the dropdown is visible, click anywhere outside dropdown

Expected

dropdown should disappear

Actual

dropdown is visible


I find this callback doesn't fired when the dropdownview closed .
now I don't understand why ... . (it worked well in IE)
dropdown_view.js

_handleMouseleave: function() {
      this.isMouseOverDropdown = false;// 
}
@jharding
Copy link
Contributor

I'm guessing this is related to #242. My plan is to investigate the issue this weekend and hopefully get patch out ASAP. Thanks for the report.

stylenclass added a commit to stylenclass/typeahead.js that referenced this issue May 26, 2013
- I have added a false boolean on close function. Basically this boolean is responsible for closing the dropdown or not via closeUnlessMouseIsOverDropdown function.
@stylenclass
Copy link
Contributor

@jharding
just issued a pull request, one line of code fixes 2 bugs #242 and #259

@jharding
Copy link
Contributor

Great, thanks @stylenclass.

jharding pushed a commit that referenced this issue May 29, 2013
- I have added a false boolean on close function. Basically this boolean is responsible for closing the dropdown or not via closeUnlessMouseIsOverDropdown function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants