Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List jquery as a dependency in package.json #1143

Closed
matthewp opened this issue Mar 17, 2015 · 1 comment
Closed

List jquery as a dependency in package.json #1143

matthewp opened this issue Mar 17, 2015 · 1 comment
Milestone
v0.11.1

Comments

@matthewp
Copy link

The reason #872 happens is because jquery is not a dependency in your package.json. Adding it should make browserify/webpack work with no extra shimming necessary. Would you be open to this? If so I can send a PR.
@matthewp matthewp mentioned this issue Mar 17, 2015
Closed
@kanejoe
Copy link

kanejoe commented Apr 14, 2015

+1

@jharding jharding added this to the v0.11.1 milestone Apr 25, 2015
jharding added a commit that referenced this issue Apr 26, 2015
@jharding
Merge pull request #1179 from jharding/1143-list-jquery-dependency
4ac1777 
List jquery as dependency in package.json. Fixes #1143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v0.11.1
Development

No branches or pull requests
3 participants
@kanejoe @jharding @matthewp