-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Volume Profile #320
Conversation
…me based on price direction, not volume direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good and the fixes are welcome 😄.
I only suggest not changing lines 23-27 since some may pass in a different source for whatever reason.
Aha, thanks for the observation; I did not realize what was going on with the Series names. Fixed. I also updated the docstring. User jeichenseerNRX is also me - I need to sort out my SSH keys. = / |
No worries. Thanks for improving vp promptly. 😎 I will roll it into the development branch soon and let you know when it's ready to check out before I push it to main. Thanks, |
Hello @delicateear, I pushed it to the development branch if you want to check it out before it's pushed to main. $ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development Thanks for the contribution. 😎 KJ |
Looks good to me. 👍🏾 |
Thank you Sir. KJ |
Divide bins evenly by price if sort_close. Fixes #318
Positive and negative volume based on price direction, not volume direction. Fixes #319
Minor refactoring for clarity.