Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Volume Profile #320

Merged
merged 3 commits into from
Jul 2, 2021
Merged

Fixes for Volume Profile #320

merged 3 commits into from
Jul 2, 2021

Conversation

delicateear
Copy link
Contributor

Divide bins evenly by price if sort_close. Fixes #318

Positive and negative volume based on price direction, not volume direction. Fixes #319

Minor refactoring for clarity.

…me based on price direction, not volume direction.
Copy link
Owner

@twopirllc twopirllc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good and the fixes are welcome 😄.

I only suggest not changing lines 23-27 since some may pass in a different source for whatever reason.

@delicateear
Copy link
Contributor Author

Aha, thanks for the observation; I did not realize what was going on with the Series names. Fixed.

I also updated the docstring. User jeichenseerNRX is also me - I need to sort out my SSH keys. = /

@twopirllc
Copy link
Owner

@delicateear,

Aha, thanks for the observation; I did not realize what was going on with the Series names. Fixed.
I also updated the docstring. User jeichenseerNRX is also me - I need to sort out my SSH keys. = /

No worries. Thanks for improving vp promptly. 😎 I will roll it into the development branch soon and let you know when it's ready to check out before I push it to main.

Thanks,
KJ

twopirllc added a commit that referenced this pull request Jun 28, 2021
@twopirllc
Copy link
Owner

Hello @delicateear,

I pushed it to the development branch if you want to check it out before it's pushed to main.

$ pip install -U git+https://github.com/twopirllc/pandas-ta.git@development

Thanks for the contribution. 😎

KJ

@delicateear
Copy link
Contributor Author

Looks good to me. 👍🏾
jhno

@twopirllc
Copy link
Owner

@delicateear,

Thank you Sir.

KJ

@twopirllc twopirllc merged commit 47dd6ed into twopirllc:main Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants