Change JVM options. remove MaxPermSize and add +UseStringDeduplication #763
Conversation
|
Do you have numbers for the 500K jobs after these changes? |
|
Not yet. I'll test and have numbers soon.... |
|
Something ate my old response.. Anyways, this code is only used for lein test and internal use. In production, the ansible configuration is used to construct the command line. So (AFAIK), I can't test and give real numbers until we deploy that change and (unless you are aware of a way to do a one-off launch with a custom command line) |
scrosby
force-pushed
the
outgoing/deduplication
branch
from
4914d76
to
7f66268
Compare
scrosby
force-pushed
the
outgoing/deduplication
branch
from
7f66268
to
0ef3c26
Compare
|
Turned it on in a test enviornment. With 100k jobs in the queue, the number of char arrays is a third of the number of strings, before they were nearly identical. Memory usage for strings has dropped by a lot. UUID storage now dominates the heap. |
| "-XX:MaxPermSize=500M" | ||
| "-XX:+UseG1GC" | ||
| "-XX:+UseStringDeduplication" | ||
| "-XX:+PrintStringDeduplicationStatistics" |
There was a problem hiding this comment.
I had to comment out -XX:+UseStringDeduplication and -XX:+PrintStringDeduplicationStatistics in order to get my local cook scheduler to start up. Is there something I'm missing @scrosby?
…plication (twosigma#763)" Our integration test environment is based around mesos docker 1.3, which ends up running JDK7, which requires the old options. This reverts commit 46f0867.
…plication (twosigma#763)" (twosigma#785) Our integration test environment is based around mesos docker 1.3, which ends up running JDK7, which requires the old options. This reverts commit 46f0867.
Changes proposed in this PR
Switch to G1GC and turn on string deduplication.
Remove deprecated JDK option
Why are we making these changes?