#7644 fix spark status toolbar indicators change size on nb switch (#…

…7647)
twosigma · Jul 4, 2018 · 401e0b2 · 401e0b2
1 parent 910e390
commit 401e0b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/js/notebook/src/SparkStateProgress.ts b/js/notebook/src/SparkStateProgress.ts
@@ -91,8 +91,6 @@ export class SparkStateProgressView extends widgets.VBoxView {
     this.progressLabelWaiting.innerText = `${valueWaiting}`;
     this.progressLabelAll.innerText = max;
 
-    this.updateLabelWidths();
-
     return super.update();
   }
 
@@ -205,6 +203,8 @@ export class SparkStateProgressView extends widgets.VBoxView {
     this.progressLabelWaiting = this.progressLabels.querySelector('.waiting');
     this.progressLabelAll = this.progressLabels.querySelector('.all');
 
+    this.updateLabelWidths();
+
     return $(this.progressLabels);
   }
 

diff --git a/js/notebook/src/SparkUI.ts b/js/notebook/src/SparkUI.ts
@@ -351,8 +351,6 @@ export class SparkUIView extends widgets.VBoxView {
     this.connectionLabelMemory.innerText = `${bkUtils.formatBytes(storageMemory)}`;
     this.connectionLabelDead.innerText = `${deadExecutors}`;
     this.toolbarSparkConnectionStatus.propagateToolbarWidget();
-
-    this.updateLabelWidths();
   }
 
   private updateLabelWidths() {
@@ -363,11 +361,11 @@ export class SparkUIView extends widgets.VBoxView {
     container.innerText = '999';
     container.classList.add('label');
 
-    this.sparkStats.node.appendChild(container);
+    document.body.appendChild(container);
     const maxWidth1 = `${container.offsetWidth}px`;
     container.innerText = '999 GB';
     const maxWidth2 = `${container.offsetWidth}px`;
-    this.sparkStats.node.removeChild(container);
+    document.body.removeChild(container);
 
     this.connectionLabelActive.style.width = maxWidth1;
     this.connectionLabelDead.style.width = maxWidth1;