#7670 open autotranslation comm after registering extension

twosigma · Jul 11, 2018 · c911e5a · c911e5a
1 parent 0edcc20
commit c911e5a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/js/lab/src/plugin/autotranslation.ts b/js/lab/src/plugin/autotranslation.ts
@@ -27,6 +27,7 @@ export namespace Autotranslation {
 
     kernelInstance.connectToComm(BEAKER_AUTOTRANSLATION)['then'](comm => {
       autotranslationComm = comm;
+      autotranslationComm.open();
     });
 
     const handler = {

diff --git a/js/lab/src/plugin/initializationCells.ts b/js/lab/src/plugin/initializationCells.ts
@@ -37,17 +37,19 @@ export function enableInitializationCellsFeature(panel: NotebookPanel): void {
 }
 
 export function runInitCells(panel: NotebookPanel, options: IInitCellsOptions): void {
-  const cells: CodeCell[] = getInitCells(panel);
-
-  handleUntrustedKernelInitCells(cells, options);
-
-  if (!canExecuteInitCells(panel, options, cells)) {
-    return;
-  }
-
-  console.log(logPrefix, 'running all initialization cells');
-  cells.forEach((cell: CodeCell) => CodeCell.execute(cell, panel.session));
-  console.log(logPrefix, `finished running ${cells.length} initialization cell${(cells.length !== 1 ? 's' : '')}`);
+  panel.ready.then(() => {
+    const cells: CodeCell[] = getInitCells(panel);
+
+    handleUntrustedKernelInitCells(cells, options);
+
+    if (!canExecuteInitCells(panel, options, cells)) {
+      return;
+    }
+
+    console.log(logPrefix, 'running all initialization cells');
+    cells.forEach((cell: CodeCell) => CodeCell.execute(cell, panel.session));
+    console.log(logPrefix, `finished running ${cells.length} initialization cell${(cells.length !== 1 ? 's' : '')}`);
+  });
 }
 
 export function getInitCells(panel: NotebookPanel): CodeCell[] {