#7236 scroll by page when focused cell is not set

twosigma · Apr 26, 2018 · e81fe56 · e81fe56
1 parent 63eb614
commit e81fe56
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/js/notebook/src/tableDisplay/dataGrid/BeakerXDataGrid.ts b/js/notebook/src/tableDisplay/dataGrid/BeakerXDataGrid.ts
@@ -48,6 +48,7 @@ import ColumnPosition from "./column/ColumnPosition";
 import {SectionList} from "@phosphor/datagrid/lib/sectionlist";
 import ColumnRegion = DataModel.ColumnRegion;
 import {DataGridResize} from "./DataGridResize";
+import {KEYBOARD_KEYS} from "./event/enums";
 
 export class BeakerXDataGrid extends DataGrid {
   id: string;

diff --git a/js/notebook/src/tableDisplay/dataGrid/event/EventManager.ts b/js/notebook/src/tableDisplay/dataGrid/event/EventManager.ts
@@ -330,7 +330,11 @@ export default class EventManager {
       return;
     }
 
-    this.dataGrid.cellFocusManager.setFocusedCellByNavigationKey(code);
+    if (this.dataGrid.cellFocusManager.focusedCellData) {
+      this.dataGrid.cellFocusManager.setFocusedCellByNavigationKey(code);
+    } else if (code === KEYBOARD_KEYS.PageDown || code === KEYBOARD_KEYS.PageUp) {
+      this.dataGrid.scrollByPage(code === KEYBOARD_KEYS.PageUp ? 'up' : 'down');
+    }
 
     if (event.shiftKey) {
       this.dataGrid.cellSelectionManager.setEndCell(