Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax highlighter does not understand magics #5742

Closed
scottdraves opened this issue Jul 25, 2017 · 2 comments
Closed

syntax highlighter does not understand magics #5742

scottdraves opened this issue Jul 25, 2017 · 2 comments
Assignees
@MariuszJurowicz
Labels
Bug Notebook Extension

Comments

@scottdraves
Copy link
Contributor

screen shot 2017-07-25 at 5 22 40 pm
@scottdraves scottdraves changed the title code formatter does not understand magics syntax highlighter does not understand magics Jul 25, 2017
@piorek
Copy link
Contributor

piorek commented May 4, 2018

Probably should be done with custom mode (http://marijnhaverbeke.nl/blog/codemirror-mode-system.html)
will need a list of magics or some general rule how to distinguish them from the rest of the code

@scottdraves
Copy link
Contributor Author

let's say any line that starts with a %

@scottdraves scottdraves assigned MariuszJurowicz and unassigned piorek Jul 3, 2018
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 add highlight support for jvm kernels magics
1c8d0c8
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 define line magic highlighter mode
3ae9425
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 remove GrovyMode namespace, update types
b165501
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 add line magic highlighting in Lab
7390db3
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 highlight Spark and classpath magics
cca204f
MariuszJurowicz pushed a commit that referenced this issue Jul 6, 2018
#5742 support line magics not only in first line of cell
d9fd953
LeeTZ pushed a commit that referenced this issue Jul 12, 2018
@LeeTZ
#5742 add highlight support for jvm kernels magics (#7662)
a731c60 
* #5742 add highlight support for jvm kernels magics

* #5742 define line magic highlighter mode

* #5742 remove GrovyMode namespace, update types

* #5742 add line magic highlighting in Lab

* #5742 highlight Spark and classpath magics

* #5742 support line magics not only in first line of cell
@LeeTZ LeeTZ closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariuszJurowicz MariuszJurowicz

Labels
Bug Notebook Extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@piorek @scottdraves @LeeTZ @MariuszJurowicz @jaroslawmalekcodete