Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heap size must be positive #6478

Closed
scottdraves opened this issue Dec 8, 2017 · 1 comment
Closed

heap size must be positive #6478

scottdraves opened this issue Dec 8, 2017 · 1 comment
Assignees
@piorek @scottdraves
Labels
Bug Notebook Extension

Comments

@scottdraves
Copy link
Contributor

also show an error if the heap size is zero or negative, in addition to numeric.

screen shot 2017-12-07 at 9 23 56 pm
piorek pushed a commit that referenced this issue Dec 11, 2017
commit contains following changes:
0751551 
- #6371 refactor
- #6371 sync options continuously
- #6371 fix some load quirks:
  - loading twice
  - loading on tab click when tab is active
  - last version not loaded in some cases
- #6478 heap size must be positive
@piorek piorek mentioned this issue Dec 11, 2017
Merged
scottdraves pushed a commit that referenced this issue Jan 5, 2018
@piorek @scottdraves
#6371 get rid of the OK button (#6487)
d86effc 
* #6371 remove OK button from template

* commit contains following changes:

- #6371 refactor
- #6371 sync options continuously
- #6371 fix some load quirks:
  - loading twice
  - loading on tab click when tab is active
  - last version not loaded in some cases
- #6478 heap size must be positive

* #6371 remove invalid if statement

* #6371 use _.debounce, implement synchronization indicator

* #6371 change sync indicator place in template

* #6371 fix losing focus after sync, and tabing issue

* #6371 sync empty values; add only missing inputs when loading settings

* #6371 fix code style (jscs)

* #6371 do not send invalid heap size

* #6371 add additional check when validating heap size

* #6371 do not sync data when heap size is invalid
scottdraves pushed a commit that referenced this issue Jan 9, 2018
@piorek @scottdraves
#6371 get rid of the OK button (#6614)
ad34536 
* #6371 remove OK button from template

* commit contains following changes:

- #6371 refactor
- #6371 sync options continuously
- #6371 fix some load quirks:
  - loading twice
  - loading on tab click when tab is active
  - last version not loaded in some cases
- #6478 heap size must be positive

* #6371 remove invalid if statement

* #6371 use _.debounce, implement synchronization indicator

* #6371 change sync indicator place in template

* #6371 fix losing focus after sync, and tabing issue

* #6371 sync empty values; add only missing inputs when loading settings

* #6371 fix code style (jscs)

* #6371 do not send invalid heap size

* #6371 add additional check when validating heap size

* #6371 do not sync data when heap size is invalid

* #6371 heap_GB has to be float

* #6371 move heap_GB to the correct place in data struct
@piorek
Copy link
Contributor

piorek commented Jan 10, 2018

can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piorek piorek

@scottdraves scottdraves

Labels
Bug Notebook Extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piorek @scottdraves