use a variable not string replace for $ in table filters

[scottdraves]

beakerx/js/notebook/src/tableDisplay/dataGrid/column/ColumnFilter.ts

Line 129 in c9b0dcd

private createFilterExpression(value: any): string {

[mpilosov]

Hello. I'm using beakerx for the first time (specifically intrigued by the table-filtering features for quick data processing), and no matter what I try, I cannot get the filters to apply. I've tried $, I've tried the variable name exactly, < and > , periods, quotes, hitting enter, hitting x, resetting, restarting, and just cannot get the table to filter out any of the data.

is this at all related to this issue? don't want to open up a new issue without checking first.

[scottdraves]

Hi, welcome to BeakerX :)
Thank you for your question.

This issue is about the style of the code that implements filters. The filters work fine as far as I know. Here's a screenshot of an example from our tables tutorial, which you can run on Binder:

If you have an example where it doesn't work please file a new issue and describe how to reproduce it. I would appreciate it.

[mpilosov]

is it supposed to run once I click out of the text area? I’ve been using the syntax I saw in the tutorial but the filter just didn’t seem to reduce the dataset no matter how I tried to do so. I didn’t want to open an issue until I could rule out that I did something wrong. Thanks for your prompt reply and welcome! I appreciate it.

…

On May 31, 2018, at 7:14 AM, Scott Draves ***@***.***> wrote: Hi, welcome to BeakerX :) Thank you for your question. This issue is about the style of the code that implements filters. The filters work fine as far as I know. Here's a screenshot of an example from our tables tutorial, which you can run on Binder: <https://user-images.githubusercontent.com/963093/40784143-c1668d80-64b2-11e8-8c92-b706cb334efd.png> If you have an example where it doesn't work please file a new issue and describe how to reproduce it. I would appreciate it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7295 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APidDiUkQsMOevsH53nI9EwN2y--4eV3ks5t3-yugaJpZM4Tvfhe>.

[scottdraves]

it runs as you type.

[MariuszJurowicz]

@scottdraves
In current solution this issue cannot be solved as the expression is created once per row, not per column so there can not be many variables called $ as you can use the $ for each column.
Currently the expressions for each column are concatenated just before evaluation. The sample expression can look like:

"var index = row.index;var m3 = row.values[0];var y30 = row.values[1];var y1 = row.values[2];var m6 = row.values[3];var y2 = row.values[4];var y10 = row.values[5];var y3 = row.values[6];var time = row.values[7];var y5 = row.values[8];var y7 = row.values[9];var spread = row.values[10]; y30>8.5 && y2>8"

See the last instruction y30>8.5 && y2>8. With the $ variable it would end up with something like var $=9;var $=10; $>8.5 && $>8;