Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark theme fixes #7517

Closed
15 tasks done
scottdraves opened this issue Jun 12, 2018 · 2 comments
Closed
15 tasks done

dark theme fixes #7517

scottdraves opened this issue Jun 12, 2018 · 2 comments
Assignees
@piorek
Labels
Bug Widgets JS

Comments

@scottdraves
Copy link
Contributor

scottdraves commented Jun 12, 2018 •
edited by piorek
Loading

EasyForm

the following components have a white bkg:

  • password,
  • combo box,
  • editable combo box,
  • list single,
  • and date.

also,

  • the text in the form title is too black,
  • the the border around the form is too bright.

Plots

  • please make the text (title, tick labels, text items, legend) the same brightness as regular body markdown text.

  • make the plot bkg same as page background (lose a rectangle).

  • the plot tooltips need dark theme:
    screen shot 2018-06-12 at 3 43 35 pm

Table

  • fix color of selected cells and current cell (use blue and green, 266196 and 198e1d)

screen shot 2018-06-12 at 10 47 45 pm

  • table tooltips

screen shot 2018-06-12 at 10 52 41 pm

  • color by unique, use dark colors instead of light:

screen shot 2018-06-12 at 10 58 20 pm

  • there is an extra rectangle. this rectangle turns green when you select and interact with the table.
    it should not be there at all if the table is not focused.

screen shot 2018-06-12 at 11 00 01 pm

  • for table headers and rulers, please match:

screen shot 2018-06-12 at 11 03 32 pm

except stronger/more-contrast especially between even/odd rows.
@scottdraves scottdraves changed the title some easyform components break dark theme dark theme fixes Jun 13, 2018
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 plot improvements and fixes
6dbe85c
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 add missing base styles
90f64c5
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 wip
317fe78 
- remove unnecessary Data grid border
- dark style for table tooltip
- dark fieldset styles
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 change current and selected cell color in table
9dae7b9
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 fix dark combobox styles
18e7bcc
piorek added a commit that referenced this issue Jun 13, 2018
@piorek
#7517 fix dark combobox styles
a52b374
@scottdraves
Copy link
Contributor Author

also, the spark UI start spinner is too hard to see:
screen shot 2018-06-13 at 10 37 50 am

piorek added a commit that referenced this issue Jun 14, 2018
@piorek
#7517 change table selection and border colors
3377236
piorek added a commit that referenced this issue Jun 14, 2018
@piorek
#7517 date picker dark theme
24bdc2f
piorek added a commit that referenced this issue Jun 14, 2018
@piorek
#7517 refactor spark spinner - move styles from View to .scss file
3ad8403
piorek added a commit that referenced this issue Jun 14, 2018
@piorek
#7517 make spark spinner lighter when in dark theme
753caf2
piorek added a commit that referenced this issue Jun 14, 2018
@piorek
#7517 make unique highlighter work when using dark theme
11074ba
@piorek
Copy link
Contributor

piorek commented Jun 14, 2018

Also made spark ui start spinner lighter blue in dark theme

scottdraves pushed a commit that referenced this issue Jun 14, 2018
@piorek @scottdraves
#7517 dark theme fixes and improvements (#7529)
4530d88 
* #7517 plot improvements and fixes

* #7517 add missing base styles

* #7517 wip

- remove unnecessary Data grid border
- dark style for table tooltip
- dark fieldset styles

* #7517 change current and selected cell color in table

* #7517 fix dark combobox styles

* #7517 fix dark combobox styles

* #7517 change table selection and border colors

* #7517 date picker dark theme

* #7517 refactor spark spinner - move styles from View to .scss file

* #7517 make spark spinner lighter when in dark theme

* #7517 make unique highlighter work when using dark theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@piorek piorek

Labels
Bug Widgets JS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@piorek @scottdraves