Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5798 scala interfaces part 2a #5889

Merged
merged 3 commits into from
Aug 30, 2017
Merged

5798 scala interfaces part 2a #5889

merged 3 commits into from
Aug 30, 2017

Conversation

jpallas
Copy link
Contributor

@jpallas jpallas commented Aug 29, 2017

In my previous PR, I said I had thought there were more of these. I was right. I somehow overlooked the use of AnyVal in Text, ConstantLine, and Rasters. Verified that BigInt and BigDecimal now work with these (subject to limitations in the JSON transcoding).

PS I hope that github is smart enough to ignore the commits that were already merged.

@scottdraves scottdraves merged commit ea71463 into twosigma:master Aug 30, 2017
@scottdraves
Copy link
Contributor

awesome thank you.

MariuszJurowicz pushed a commit that referenced this pull request Aug 30, 2017
@jpallas
5798 scala interfaces part 2a (#5889)
8f8f57f 
* #5798 Use Any instead of AnyVal in Line constructor

* #5798 Use Any instead of AnyRef in TableDisplay

* #5798 Use Any instead of AnyVal in Text, Rasters, and ConstantLine
@jpallas jpallas deleted the 5798-scala-interfaces branch September 11, 2017 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpallas @scottdraves