Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7061 DataGrid resize feature #7197

Merged
merged 5 commits into from
Apr 20, 2018
Merged

#7061 DataGrid resize feature #7197

merged 5 commits into from
Apr 20, 2018

Conversation

MariuszJurowicz
Copy link
Contributor

No description provided.

@scottdraves
Copy link
Contributor

has some issues. after using it for a while i got this error:

VM99 index.js:138226 Uncaught TypeError: Cannot read property 'region' of null
    at EventManager.handleMouseDown (VM99 index.js:138226)

sometimes the blue rect got left on after mouse up.
try resizing to make the table as short as possible, then drag to make it tall.

@scottdraves
Copy link
Contributor

if you drag quickly to vertically to increase the size, and the mouse leaves the output area, then the resize stops.

if you drag to vertically to decrease the size, and the mouse moves above the table and leaves the output area, then the table jumps to very large size.

when i resize horizontally, it looks good, but my change is immediately undone. i guess the handler for horizontal resize has triggered. if this is not easy to fix then just remove horizontal dragging.

@scottdraves scottdraves merged commit 0d5b5fb into master Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants