Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6688 dark theme #7478

Merged
merged 16 commits into from
Jun 12, 2018
Merged

#6688 dark theme #7478

merged 16 commits into from
Jun 12, 2018

Conversation

piorek
Copy link
Contributor

@piorek piorek commented Jun 5, 2018

  • menus in plot and data grid
  • Data grids styles after sorting
  • spark ui style after connecting (alignment is off)
  • plot text item color (black text and arrows)
  • resize thumb missing in plots

@scottdraves
Copy link
Contributor

this loses the fonts?

@piorek
Copy link
Contributor Author

piorek commented Jun 8, 2018

probably incorrectly resolved merge conflict. Its ok now.

@piorek piorek changed the title WIP #6688 dark theme #6688 dark theme Jun 8, 2018
@scottdraves
Copy link
Contributor

This is looking good but I found a few crashes. In PlotFeatures.ipynb, the Text cell crashes with:

index.js:12319 Uncaught (in promise) TypeError: Cannot read property 'substr' of undefined
    at Object.createColor (index.js:12319)
    at r.format (index.js:80390)
    at new r (index.js:80382)
    at Object.createPlotItem (index.js:50529)
    at Object.formatModel (index.js:50285)
    at Object.standardizeModel (index.js:49942)
    at M.standardizeData (index.js:37430)
    at M.init (index.js:37516)
    at initStandardPlot (index.js:64851)
    at index.js:64756

the main Charting.ipynb example fails the same way.

and the %%spark magic crashes with:

java.lang.RuntimeException: java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.lang.String

@piorek
Copy link
Contributor Author

piorek commented Jun 11, 2018

I'm not able to reproduce those errors

@scottdraves
Copy link
Contributor

spark magic crash does not appear on my other machine,
but the substr of undefined problem looks real.
please work with LM tomorrow to straighten it out.

@scottdraves scottdraves merged commit fe75cc7 into master Jun 12, 2018
@piorek piorek deleted the lukasz/6688_dark_theme branch June 20, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants