Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7332 SparkUI - saving and loading configuration profiles #7528

Merged
merged 10 commits into from
Jun 19, 2018

Conversation

lmitusinski
Copy link
Contributor

No description provided.

@scottdraves
Copy link
Contributor

scottdraves commented Jun 15, 2018

Cool this works -- how about these additions:

  • This way of storing a dict in beakerx.json:
"spark_options": {
      "prof A": {

for the profiles, use an array of name/value objects, like we do for jvm properties:

{
    "beakerx": {
        "jvm_options": {
            "other": [],
            "properties": [
                {
                    "name": "a",
                    "value": "b"
                }
            ]
  • If profile is not used, still save form values into beakerx.json, in its own section.

  • Fields have different typeface size, "Profile" is bigger.
    screen shot 2018-06-14 at 10 28 02 am

@scottdraves
Copy link
Contributor

scottdraves commented Jun 15, 2018

Thanks that's great, after playing with it I think

  • a dropdown will work better than a editable combo box. That will probably fix the font issue, the alignment of the label, and be easier to use.

  • But the user still needs a place to type a name for when they want to create a new profile. So add a new button to the right of "save". label is "+", it creates a new profile. It should popup a modal dialog that asks what to name it, with OK/cancel buttons.

  • Tooltip for "+": "Create new profile", tooltip for "x": "Delete this profile". tooltip for "save": "save profile"

  • the name of the current profile should be saved as well, so if i use the profile dropdown and select one, and click "start", then rerun jupyter and open the spark UI, the same profile should be named and loaded.

  • therefor the beakerx.json format should be adjusted. use this:

"spark_options": {
  "current_profile": "X"
  "profiles": [ {"name": "X", "config": {...}},
                {"name": "Y", "config": {...}}
              ]
}
  • save button should be disabled if there is nothing to save.
  • "Default" should just be blank.

@scottdraves scottdraves merged commit 8b907d0 into master Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants