-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5560 rewrite the plot domain mapping, range and axis #7707
Conversation
this.update(); | ||
}; | ||
|
||
PlotScope.prototype.calcMapping = function(emitFocusUpdate) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjurowicz-xsolve Is it used anywhere? It looks like it's not needed anymore. But maybe I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's used in CombinedPlots
yet
this.axisValSpan = plotUtils.minus(this.axisValR, this.axisValL); | ||
} | ||
|
||
setTimeAxisRange(para) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a meaningful name like axisTimezone perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've missed that
this.axisValSpan = plotUtils.minus(this.axisValR, this.axisValL); | ||
} | ||
|
||
setLogAxisBase(para) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
para -> axisBase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've missed that
No description provided.