Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark dlsym with __attribute__((noinline)). #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark dlsym with __attribute__((noinline)). #2

wants to merge 1 commit into from

Commits on Jun 25, 2021

  1. Mark dlsym with __attribute__((noinline)). 

    In some circumstances (e.g. under higher optimization modes when
compiled with LLVM), `dlsym` gets inlined into `libvirtcpuid_init_dso`.

When this happens, dlsym's use of `__builtin_return_address(0)` no
longer returns the address of `dlsym` and instead returns the address of
`libvirtcpuid_init_dso`. When that happens, `_dl_sym` fails to find the
next `dlsym` and the process crashes.
    @eatnumber1
    eatnumber1 committed Jun 25, 2021
    Configuration menu
    Copy the full SHA
    f39b682 View commit details
    Browse the repository at this point in the history