Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use systemd socket activation becuase startup ordering is weird. #10

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

geofft
Copy link
Collaborator

@geofft geofft commented Mar 8, 2021

Fixes #9.

Co-authored-by: Geoffrey Thomas geofft@twosigma.com

Fixes #9.

Co-authored-by: Geoffrey Thomas <geofft@twosigma.com>
@geofft geofft merged commit 1dd3264 into main Mar 9, 2021
@geofft geofft deleted the systemd branch March 9, 2021 00:27
@flokli
Copy link
Contributor

flokli commented Nov 5, 2022

This might have gotten fixed upstream in systemd/systemd-stable@5da595d btw

@pkern
Copy link

pkern commented Dec 17, 2023

I wonder if we could undo this eventually (I don't have real world data to back this though), because without socket activation binaries that require nsncd need to take an explicit systemd service dependency on it (well, a Wants=). Which I guess is kinda fine except that it does not provide the transparent system support for them anymore.

@leifwalsh
Copy link
Collaborator

@pkern if I still understand #9 correctly, such a system would deadlock if they do a lookup during their activation. If you're able to test it and show that it doesn't, that would be pretty exciting.

Can I leave you to that and to let us know if you have trouble setting up a test?

@flokli
Copy link
Contributor

flokli commented Apr 29, 2024

I'd be up to giving this another go - it might get rid of some spurious user lookup failures we have during NixOS system activations if both nsncd and a service referring to a dynamic user (provided by nss-systemd) are restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

systemd deadlock with socket activation
4 participants