factor erange handling into its own function #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifwalsh
force-pushed
the
refactor-erange
branch
6 times, most recently
from
d0f1a80 to
081ee33
Compare
leifwalsh
force-pushed
the
refactor-erange
branch
from
081ee33 to
acd766c
Compare
morisja
approved these changes
Oct 12, 2024
|
Nice. FTR, we have a few occurences of this pattern in src/ffi.rs. |
|
ah I should prob move a number of the functions I just added for service and netgroup to ffi.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.