-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix group passwd #55
fix group passwd #55
Conversation
Sorry, we didn't see this. Would you mind rebasing your branch to trigger checks to run again? |
Could you please also fill out and send https://github.com/twosigma/nsncd/blob/main/cla/TSOS%20CLA%20-%20Individual%20-%20nsncd.pdf so we can accept your contribution? |
rebase on the dev branch? OK!
I've never filled something like this. Maybe I need some time to read it... |
Looks good, @SaltyKitkat! We just need your CLA and then we can merge! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
==========================================
+ Coverage 41.60% 41.75% +0.15%
==========================================
Files 6 6
Lines 274 273 -1
==========================================
Hits 114 114
+ Misses 160 159 -1
☔ View full report in Codecov by Sentry. |
5566834
to
32795f8
Compare
@SaltyKitkat have you sent that CLA yet? |
Sorry, I was so busy these days that I forgot this pr. I'm afraid that I cant send the file to you. Sending international express delivery is too troublesome for me. Or may I only send you the PDF file? |
Yeah, PDF should be fine! |
Actually, I'm just going to cite #35 (comment) as precedent and say this is also de minimis and doesn't need a CLA. Will merge if checks pass after rebase. cc @geofft |
Since nix crate now provide passwd in
Group
, we can make use of it now.`