Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix group passwd #55

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix group passwd #55

merged 2 commits into from
Oct 31, 2023

Conversation

SaltyKitkat
Copy link
Contributor

Since nix crate now provide passwd in Group, we can make use of it now.`

@leifwalsh leifwalsh self-requested a review February 5, 2023 17:42
@leifwalsh
Copy link
Collaborator

Sorry, we didn't see this. Would you mind rebasing your branch to trigger checks to run again?

@leifwalsh
Copy link
Collaborator

Could you please also fill out and send https://github.com/twosigma/nsncd/blob/main/cla/TSOS%20CLA%20-%20Individual%20-%20nsncd.pdf so we can accept your contribution?

@SaltyKitkat
Copy link
Contributor Author

Sorry, we didn't see this. Would you mind rebasing your branch to trigger checks to run again?

rebase on the dev branch? OK!

Could you please also fill out and send https://github.com/twosigma/nsncd/blob/main/cla/TSOS%20CLA%20-%20Individual%20-%20nsncd.pdf so we can accept your contribution?

I've never filled something like this. Maybe I need some time to read it...
I'll fill out and send it ASAP.

@leifwalsh
Copy link
Collaborator

Looks good, @SaltyKitkat! We just need your CLA and then we can merge!

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (125cb88) 41.60% compared to head (32795f8) 41.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   41.60%   41.75%   +0.15%     
==========================================
  Files           6        6              
  Lines         274      273       -1     
==========================================
  Hits          114      114              
+ Misses        160      159       -1     
Impacted Files Coverage Δ
src/handlers.rs 33.67% <0.00%> (+0.34%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leifwalsh leifwalsh force-pushed the grp_pwd branch 2 times, most recently from 5566834 to 32795f8 Compare May 5, 2023 02:01
@leifwalsh
Copy link
Collaborator

@SaltyKitkat have you sent that CLA yet?

@SaltyKitkat
Copy link
Contributor Author

SaltyKitkat commented Oct 15, 2023

@SaltyKitkat have you sent that CLA yet?

Sorry, I was so busy these days that I forgot this pr.

I'm afraid that I cant send the file to you. Sending international express delivery is too troublesome for me. Or may I only send you the PDF file?

@leifwalsh
Copy link
Collaborator

Yeah, PDF should be fine!

@leifwalsh
Copy link
Collaborator

Actually, I'm just going to cite #35 (comment) as precedent and say this is also de minimis and doesn't need a CLA. Will merge if checks pass after rebase.

cc @geofft

@leifwalsh leifwalsh merged commit bc843bd into twosigma:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants