Skip to content

Merge pull request #108 from twosigma/dependabot/cargo/anyhow-1.0.81 #570

Merge pull request #108 from twosigma/dependabot/cargo/anyhow-1.0.81

Merge pull request #108 from twosigma/dependabot/cargo/anyhow-1.0.81 #570

GitHub Actions / clippy failed Apr 23, 2024 in 0s

clippy

3 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 3
Warning 0
Note 0
Help 0

Versions

  • rustc 1.79.0-nightly (7f2fc33da 2024-04-22)
  • cargo 1.79.0-nightly (80d5b607d 2024-04-19)
  • clippy 0.1.79 (7f2fc33 2024-04-22)

Annotations

Check failure on line 46 in src/protocol.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-local `impl` definition, they should be avoided as they go against expectation

error: non-local `impl` definition, they should be avoided as they go against expectation
  --> src/protocol.rs:46:45
   |
46 | #[derive(Clone, Copy, Debug, FromPrimitive, ToPrimitive)]
   |                                             ^^^^^^^^^^^
   |
   = help: move this `impl` block outside the of the current constant `_IMPL_NUM_ToPrimitive_FOR_RequestType`
   = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
   = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
   = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
   = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive`
   = note: this error originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 46 in src/protocol.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

non-local `impl` definition, they should be avoided as they go against expectation

error: non-local `impl` definition, they should be avoided as they go against expectation
  --> src/protocol.rs:46:30
   |
46 | #[derive(Clone, Copy, Debug, FromPrimitive, ToPrimitive)]
   |                              ^^^^^^^^^^^^^
   |
   = help: move this `impl` block outside the of the current constant `_IMPL_NUM_FromPrimitive_FOR_RequestType`
   = note: an `impl` definition is non-local if it is nested inside an item and may impact type checking outside of that item. This can be the case if neither the trait or the self type are at the same nesting level as the `impl`
   = note: one exception to the rule are anon-const (`const _: () = { ... }`) at top-level module and anon-const at the same nesting as the trait or type
   = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue <https://github.com/rust-lang/rust/issues/120363>
   = note: the derive macro `FromPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive`
   = note: `-D non-local-definitions` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(non_local_definitions)]`
   = note: this error originates in the derive macro `FromPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info)

Check failure on line 101 in src/ffi.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `addr_type` is never read

error: field `addr_type` is never read
   --> src/ffi.rs:101:9
    |
98  | pub struct Hostent {
    |            ------- field in this struct
...
101 |     pub addr_type: i32,
    |         ^^^^^^^^^
    |
    = note: `Hostent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
    = note: `-D dead-code` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(dead_code)]`