MOD:remove the pod get in range pods #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I don't think it is needed any longer. I believe when I first wrote that there were no later checks. This project really needs some tests! I'll merge and test in the next day or so when I have time. |
D3-LucaPiombino
pushed a commit
to CodeCoil/kubefwd
that referenced
this pull request
Jun 13, 2024
MOD:remove the pod get in range pods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does it make sense to determine if a pod exists when traversing the pods_item data read from the service?
or other reason to determine if the pod exists or not here?
i think delete this code can clean the code.
PTAL, thanks!