Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(feat): Start linting both code and some support files #96

Merged
merged 23 commits into from
Jan 26, 2022

Conversation

mark-stopka
Copy link
Collaborator

@mark-stopka mark-stopka commented Jan 24, 2022

  • Add @mark-stopka as default reviewer for dependency updates thru Dependabot

@mark-stopka mark-stopka self-assigned this Jan 24, 2022
@mark-stopka
Copy link
Collaborator Author

Used GitHub action has an issue marocchino/validate-dependabot#233

@mark-stopka mark-stopka added automation enhancement New feature or request labels Jan 24, 2022
@mark-stopka mark-stopka marked this pull request as draft January 24, 2022 22:59
@mark-stopka mark-stopka changed the title ci(dependabot): Add default reviewer & Dependabot config validation ci(dependabot): Add default Dependabot reviewer Jan 25, 2022
@mark-stopka mark-stopka requested a review from scarmuega January 25, 2022 19:26
@mark-stopka mark-stopka marked this pull request as ready for review January 25, 2022 19:26
@mark-stopka
Copy link
Collaborator Author

@scarmuega please just approve review, I will squash and merge, it is too much mess and I was not able to fix #100

@mark-stopka mark-stopka added this to the v1.1 milestone Jan 25, 2022
.github/dependabot.yml Outdated Show resolved Hide resolved
@mark-stopka mark-stopka requested a review from scarmuega January 26, 2022 00:00
Copy link
Collaborator Author

@mark-stopka mark-stopka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was removed as a reviewer, can you please approve the changes?

scarmuega
scarmuega previously approved these changes Jan 26, 2022
Pipeline linting of Rust code and Support files
@mark-stopka mark-stopka changed the title ci(dependabot): Add default Dependabot reviewer ci(feat): Start linting both code and some support files Jan 26, 2022
@mark-stopka mark-stopka requested a review from scarmuega January 26, 2022 19:26
@scarmuega scarmuega merged commit 50fdb12 into main Jan 26, 2022
@scarmuega scarmuega deleted the ci_dependabot_add_default_reviewer branch January 26, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants