Fix: Prevent inaccessible calendars from deleting #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A calendar that is inaccessible when the integration is starting up primarily during a restart of HA, but also when the integration is reloaded, could potentially cause currently defined lock slots to get deleted. This can cause major issues, particularly if the slot had an override on the code in place as the override is lost. Instead, we keep the sensors as unavailable and do not fire any events related to setting or clearing the the codes until we have managed to load the calendar successfully. Issue: Fixes #126 Signed-off-by: Andrew Grimberg <tykeal@bardicgrove.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A calendar that is inaccessible when the integration is starting up
primarily during a restart of HA, but also when the integration is
reloaded, could potentially cause currently defined lock slots to get
deleted. This can cause major issues, particularly if the slot had an
override on the code in place as the override is lost.
Instead, we keep the sensors as unavailable and do not fire any events
related to setting or clearing the the codes until we have managed to
load the calendar successfully.
Issue: Fixes #126
Signed-off-by: Andrew Grimberg tykeal@bardicgrove.org