Add 7 languages from the bip39 spec #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Italian, with included crc32 checksum protections. A small reorganization to account for more languages.
|
@tyler-smith ping (and thanks) |
|
@cornfeedhobo Thanks for the submission. It looks good, but I'm going to play with it some and think about potential issues or changes and then merge it if everything still looks good. I'm thinking we might want to tweak the API eventually to make language selection easier but we can do that as a second step later on. I'll think about how it should work while experimenting with this PR. |
|
@tyler-smith Sounds good. I already have some thoughts on this, but didn't want to shake things up too much with this PR. I'll try to draft up a branch for you to look at and see what I'm thinking. |
|
All manual and automated tests/test vectors are passing for me. Thanks again for the submission @cornfeedhobo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Japanese, Korean, Spanish, Chinese (simplified and traditional), and Italian, with included crc32 checksum protections. A small reorganization to account for more languages.
French was not added because the official wordlist has an artifact as the first byte, making "official" crc32 checksums invalid. I am following up with bitcoin devs on this issue.
Fixes #9