refactor: make smarter by destructuring assignment

type-safe-dx · Feb 28, 2023 · 6bf8aa0 · 6bf8aa0
1 parent 42feb29
commit 6bf8aa0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/__snapshots__/index.test.ts.snap b/src/__snapshots__/index.test.ts.snap
@@ -125,9 +125,10 @@ export const createBaseFetcher = (
       body: Get<paths[Path], [Method, \\"requestBody\\", \\"content\\", \\"application/json\\"]>
     }>
   ): Promise<Get<paths[Path], [Method, \\"responses\\", 200, \\"content\\", \\"application/json\\"]>> => {
+    const { method, query, body } = opts as any
     return ownFetcher(
-      path + (\\"query\\" in opts ? \`?\${new URLSearchParams(opts.query as any)}\` : \\"\\"),
-      { method: opts.method, body: (opts as any).body }
+      path + (query ? \`?\${new URLSearchParams(query as any)}\` : \\"\\"),
+      { method, body }
     ) as any;
   };
 };

diff --git a/src/index.ts b/src/index.ts
@@ -54,9 +54,10 @@ export const createBaseFetcher = (
       body: Get<paths[Path], [Method, "requestBody", "content", "application/json"]>
     }>
   ): Promise<Get<paths[Path], [Method, "responses", 200, "content", "application/json"]>> => {
+    const { method, query, body } = opts as any
     return ownFetcher(
-      path + ("query" in opts ? \`?\${new URLSearchParams(opts.query as any)}\` : ""),
-      { method: opts.method, body: (opts as any).body }
+      path + (query ? \`?\${new URLSearchParams(query as any)}\` : ""),
+      { method, body }
     ) as any;
   };
 };

diff --git a/test/generated/index.ts b/test/generated/index.ts
@@ -122,9 +122,10 @@ export const createBaseFetcher = (
       body: Get<paths[Path], [Method, "requestBody", "content", "application/json"]>
     }>
   ): Promise<Get<paths[Path], [Method, "responses", 200, "content", "application/json"]>> => {
+    const { method, query, body } = opts as any
     return ownFetcher(
-      path + ("query" in opts ? `?${new URLSearchParams(opts.query as any)}` : ""),
-      { method: opts.method, body: (opts as any).body }
+      path + (query ? `?${new URLSearchParams(query as any)}` : ""),
+      { method, body }
     ) as any;
   };
 };