Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1/x] Fix cross-project cache invalidation #278

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

andrewchang-bird
Copy link
Contributor

@andrewchang-bird andrewchang-bird commented Jan 25, 2022

Stack

πŸ“š #279 [2/x] Fix optional members in Obj-C protocols
πŸ“š #278 ← [1/x] Fix cross-project cache invalidation

Overview

Test and source target caching is improperly invalidated when generating mocks for targets outside of the current test target context. The caching issues are compounded when generating mocks for multiple projects in the same test target. This PR fixes the caching behavior for cross-project mocking setups.

Test Plan

Validated that the test and source target caches are invalidated iff the inputs are changed.

@andrewchang-bird andrewchang-bird force-pushed the dev/andrewchang-bird/fix-multiproj-caching branch from f75db97 to 8d1607b Compare January 28, 2022 21:31
@andrewchang-bird andrewchang-bird merged commit 5e44556 into master Jan 28, 2022
@andrewchang-bird andrewchang-bird deleted the dev/andrewchang-bird/fix-multiproj-caching branch January 28, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants