[1/y] Add backwards compatibility with Swift 5.5 #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack
📚 #287 [5/y] Improve static mocking APIs
📚 #286 [4/y] Enable mocking sources in test bundles
📚 #285 [3/y] Fix read-only subscripts
📚 #284 [2/y] Fix warnings in throwing initializers
📚 #283 ← [1/y] Add backwards compatibility with Swift 5.5
Overview
Adding support for concurrency implicitly increased our minimum Swift target to 5.5.2. Trying to consume the framework on an older toolchain like Xcode 13.1 (Swift 5.5) would fail to compile. I wrapped all async/await testing interfaces in
#if swift(>=5.5.2)compilation conditions. Technically we could target Swift 5.5 for concurrency which has different platform targets (no support for older OSes), but this increases the complexity of both the framework interface and the testing matrix we need to use without much benefit.Test Plan
Added CI tests that run on Xcode 13.1 (Swift 5.5) and Xcode 13.2 (Swift 5.5.2).